26 - Githubissues

spaceshipyard / mars-rover-node-bridge

Apache License 2.0

1 stars 0 forks source link

26 #27

Closed vnabatov closed 5 years ago

chaos-adept commented 5 years ago

this PR has many changes, it makes sense to don't hold it for a long time.

at the same time, I would put several comments about i2c and motor encoder module (arduino/control-modules/motor-encoder-sensors.js).

it looks that we will have dead code for motor encoders (it makes sense to just remove it, or refactor)
if we decided to refactor the encoder module then we might extract data from I2C_DATA_RECIEVED

note: encoders are supported as it is in the current dispatcher, it might be more incremental to re-use it at first and then replace or otherwise remove it in the dispatcher as well to don't hold, dead code.

vnabatov commented 5 years ago

I've removed some extra code, will finish when got i2c to work, could you try on your side, no message on mine, probably wire problems

chaos-adept commented 5 years ago

, could you try on your side,

ok, I will

no message on mine, probably wire problems

@vnabatov Could you send photo or scheme of your wires connection between arduinos?

chaos-adept commented 5 years ago

could you try on your side, It works for me.

vnabatov commented 5 years ago

vnabatov commented 5 years ago

vnabatov commented 5 years ago

1 power uno2 from uno1 maybe it's the reason

chaos-adept commented 5 years ago

wires are connected correctly, Could you re-confirm that your custom firmata has i2c support? http://firmatabuilder.com/