spacestation13 / BYONDDiffBots

GitHub applications to render rich diffs of BYOND files
MIT License
6 stars 4 forks source link

make mdb2 use the actual git binary, make doing multiple jobs a bit less stupid #14

Closed jupyterkat closed 1 year ago

tigercat2000 commented 1 year ago

I'll leave a note here instead of in the review- we should really settle on one web framework used for both MDB and IDB lol I think it should be actix_web because Rocket interferes with tracing because it does a bunch of automatic console setup

AffectedArc07 commented 1 year ago

Will merge once coffee fixes the clippy lint, and its ran fine in prod.

Then I can begin the deprecation of MDB1 and IDB2. Bless the work of all 3 of you.

AffectedArc07 commented 1 year ago

If the GC runs fine tomorrow morning, I am hitting merge on this and retiring the old 2.

AffectedArc07 commented 1 year ago
Dec 30 04:00:00 AA07-S-UBUNTU start.sh[523505]: 04:00:00 [INFO] async_spawn_by_tokio: routine-exec; task_id=1 record_id=7014439927719006208
Dec 30 04:00:00 AA07-S-UBUNTU start.sh[523505]: 04:00:00 [INFO] Job received from queue
Dec 30 04:00:00 AA07-S-UBUNTU start.sh[523505]: 04:00:00 [INFO] Garbage collection starting!
Dec 30 04:14:58 AA07-S-UBUNTU start.sh[523505]: 04:14:58 [INFO] Garbage collection finished!

It worky!

AffectedArc07 commented 1 year ago

WE GAMING NOW