search

spacestation13 / BYONDDiffBots

GitHub applications to render rich diffs of BYOND files
MIT License
6 stars 4 forks source link

[MDB] Mob difference isn't highlighted #19

Open CheffieGithub opened 1 year ago

CheffieGithub commented 1 year ago

Description

When comparing diff between map changes, mobs aren't highlighted in red.

Steps to reproduce

  1. make a mapping change that deals with mobs
  2. view the diff
  3. cry when you can't tell what mobs are changed

Expected Behavior

All diff is highlighted for ease of viewing and review

Additional Information & Screenshots

image

Case of object critter to mob critter

AffectedArc07 commented 1 year ago

The old and new images are the same?

CheffieGithub commented 1 year ago

Yes that's the issue because they aren't the same, left the critter is an object on the right its a mob

AffectedArc07 commented 1 year ago

The diff image can only compare visual changes, the exact same issue occurs for VV edits.

Its unlikely this will ever be fixed, paging @MCHSL and @jupyterkat for thoughts.

jupyterkat commented 1 year ago

this would be a huge rework of how the diff is rendered, all for a tiny vv edit

CheffieGithub commented 1 year ago

well thats too bad then