search

spacestation13 / BYONDDiffBots

GitHub applications to render rich diffs of BYOND files
MIT License
6 stars 4 forks source link

Bug: icondiff show incorrect diffs #25

Open Dimach opened 10 months ago

Dimach commented 10 months ago

Here it show almost entire file changed, and icons shuffled randomly https://github.com/ss220-space/Paradise/pull/3342 Here it shows chnages in nianflag_fire (flags_lefthand.dmi, flags_righthand.dmi) when there was no changes, also it show wrong animation https://github.com/ss220-space/Paradise/pull/3354 When DMI files not contains animation behavior looks correct

GoldenAlpharex commented 10 months ago

I have another instance of this: https://github.com/Skyrat-SS13/Skyrat-tg/runs/16449958042

It seems as though it's not parsing the amount of frames properly, and is shifting some frames around on accident, when there's some mix between animations and non-animations within the same file.

volas commented 7 months ago

Happens often for us too, especially with some files with multiple states like inhands

https://github.com/TauCetiStation/TauCetiClassic/pull/12395/checks?check_run_id=19014059257 https://github.com/TauCetiStation/TauCetiClassic/pull/12408/checks?check_run_id=18995540656

ZeWaka commented 6 months ago

example https://github.com/goonstation/goonstation/pull/17340/checks?check_run_id=19696891644

volas commented 6 months ago

I think it's fixed in https://github.com/spacestation13/BYONDDiffBots/pull/30

fixes reading the wrong frame number from the wrong number of delays