Add temporal analysis scripts and notebooks

spacetelescope / PASTIS

Algorithm for analytical contrast predictions of coronagraphs on segmented telescopes

BSD 3-Clause "New" or "Revised" License

8 stars 4 forks source link

Add temporal analysis scripts and notebooks #121

Closed asahooexo closed 2 years ago

asahooexo commented 2 years ago

This PR contains:

1. Adding close loop recursive and batch estimation python script.
1. Use above script to do temporal stability analysis for lo, mid, hi-spatial frequency, thermal pupil wavefront aberration modes.
1. Currently the temporal analysis are presented only notebooks. for example, harris_mode.ipynb walks through a detailed full e2e analysis: starting from creating luvoir aperture, pastis multi mode matrix, tolerance maps for each of the thermal modes, compute out of band sensitivity matrix using a out of band zernike wavefront sensor, uses recursive close loop batch estimation to determine wavefront sensing time scale required to main a stable dark hole contrast (such as 10^-11 ), monte carlo simulation to validate the contrast allocation across each modal basis.
1. These notebooks will be soon changed to executable python scripts.

asahooexo commented 2 years ago

Regarding all lot branches:

I don't think feature/temporal_notebook is relevant. I would want to delete it. About feature/harris_mode_analysis, I would keep it as a remote backup as of now. You can delete/close the PR #118.

In total there are 22 branches, I have 3 branches (2 active, and 1 stale (ULTRA-14_tutorial)). I am going to delete mine stale branch.

There are 18 stale branches from you (10), Laurent (2) and David (6). Can you confirm me which ones you are planning to keep?

ivalaginja commented 2 years ago

I won't be touching Laurent's branches since I don't know their status and he is out for now. All other branches are unrelated to this work.

Yes please go ahead and delete feature/temporal_notebook in that case. What does feature/harris_mode_analysis have that this PR doesn't?

asahooexo commented 2 years ago

Deleted feature/temporal_notebook. feature/harris_mode_analysis and feature/add_temporal_nbs are almost identical. The later one was rebased yesterday with origin/develop

ivalaginja commented 2 years ago

In that case please also delete feature/harris_mode_analysis from the remote.

asahooexo commented 2 years ago

Thanks, I will delete feature/harris_mode_analysis once successfully incorporate all your changes in feature/add_temporal_nbs. For time being, I want to keep this until SPIE.

asahooexo commented 2 years ago

@ivalaginja can you please review again?