The 5 SCDA telescopes designs with their APLCs were all designed to reach an average DH mean contrast below 1e-10. We noticed that this performance was not reached in the current implementation of the simulator, except for the 1-Hex and the 2-Hex design.
The reasons for this are:
The circumscribed diameters encoded in the fits file headers of the SCDA telescope designs were scrambled and not entirely correct. @brynickson remeasured them in DS9 under the assumption that the inscribed diameter is exactly 6m for all five designs, and calculated the circumscribed (point to point) diameters from that, resulting in the following five numbers for the five designs: [7.952780833, 7.258823341, 7.72593506, 7.136856303, 6.844452477]
The Lyot stops, which all have a relative size of 98.2% of the respective inscribed diameter, also had slightly scrambled sizes.
This PR provides a temporary fix for this issue although the goal is to come back to this and understand what really caused this. The fixes that are implemented here are:
Instead of reading the circumscribed diameters of the apertures from the fits files, they are not taken from the above list.
The Lyot stops for the 3-, 4- and 5-Hex designs are now created with HCIPy on the same pupil grid like the apertures get sampled on, with diameters that were found by means of a parameter sweep, where we picked the value that gave the best contrast.
The problem that remains is that the DH morphologies are still slightly off from the design process of the APLC designs. The only design that is perfectly fine (by reading both the aperture and the LS from file) is the 2-Hex design - both the contrast performance as well as the DH morphology are what we expect from the design process. Meanwhile, the 1-hex design meets the contrast spec but does not match the DH morphology out of the box. Both of these designs are not touched in this PR.
Below a comparison between the expected DHs and DHs produced by the fixed simulator in this PR:
1-Hex expected:
1-Hex current:
2-Hex expected:
2-Hex current:
3-Hex expected (left) and current (right):
4-Hex expected (left) and current (right):
5-Hex expected (left) and current (right):
Incidentally, all the changes in this PR keep the segment size in the modal basis used for the segmented aberrations correct; there are potentially a handful of blank pixels now showing up on the edges of the segment modes, but this should not impact the performance of the simulator.
The 5 SCDA telescopes designs with their APLCs were all designed to reach an average DH mean contrast below 1e-10. We noticed that this performance was not reached in the current implementation of the simulator, except for the 1-Hex and the 2-Hex design.
The reasons for this are:
[7.952780833, 7.258823341, 7.72593506, 7.136856303, 6.844452477]
This PR provides a temporary fix for this issue although the goal is to come back to this and understand what really caused this. The fixes that are implemented here are:
The problem that remains is that the DH morphologies are still slightly off from the design process of the APLC designs. The only design that is perfectly fine (by reading both the aperture and the LS from file) is the 2-Hex design - both the contrast performance as well as the DH morphology are what we expect from the design process. Meanwhile, the 1-hex design meets the contrast spec but does not match the DH morphology out of the box. Both of these designs are not touched in this PR.
Below a comparison between the expected DHs and DHs produced by the fixed simulator in this PR:
1-Hex expected:
1-Hex current:
2-Hex expected:
2-Hex current:
3-Hex expected (left) and current (right):
4-Hex expected (left) and current (right):
5-Hex expected (left) and current (right):
Incidentally, all the changes in this PR keep the segment size in the modal basis used for the segmented aberrations correct; there are potentially a handful of blank pixels now showing up on the edges of the segment modes, but this should not impact the performance of the simulator.