spacetelescope / PASTIS

Algorithm for analytical contrast predictions of coronagraphs on segmented telescopes
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

Fix poor contrast performance of Luvex simulator #136

Closed ivalaginja closed 2 years ago

ivalaginja commented 2 years ago

The 5 SCDA telescopes designs with their APLCs were all designed to reach an average DH mean contrast below 1e-10. We noticed that this performance was not reached in the current implementation of the simulator, except for the 1-Hex and the 2-Hex design.

The reasons for this are:

This PR provides a temporary fix for this issue although the goal is to come back to this and understand what really caused this. The fixes that are implemented here are:

The problem that remains is that the DH morphologies are still slightly off from the design process of the APLC designs. The only design that is perfectly fine (by reading both the aperture and the LS from file) is the 2-Hex design - both the contrast performance as well as the DH morphology are what we expect from the design process. Meanwhile, the 1-hex design meets the contrast spec but does not match the DH morphology out of the box. Both of these designs are not touched in this PR.

Below a comparison between the expected DHs and DHs produced by the fixed simulator in this PR:

1-Hex expected:

Screen Shot 2022-07-18 at 15 57 57

1-Hex current:

Screen Shot 2022-07-18 at 15 58 43

2-Hex expected:

Screen Shot 2022-07-18 at 15 59 07

2-Hex current:

Screen Shot 2022-07-18 at 15 59 36

3-Hex expected (left) and current (right):

Screen Shot 2022-07-18 at 16 00 52

4-Hex expected (left) and current (right):

Screen Shot 2022-07-18 at 16 01 00

5-Hex expected (left) and current (right):

Screen Shot 2022-07-18 at 16 01 12

Incidentally, all the changes in this PR keep the segment size in the modal basis used for the segmented aberrations correct; there are potentially a handful of blank pixels now showing up on the edges of the segment modes, but this should not impact the performance of the simulator.

ivalaginja commented 2 years ago

The DH average contrasts measured in the current DHs are:

Screen Shot 2022-07-18 at 15 18 26