spacetelescope / STScI-STIPS

STScI-STIPS
https://stips.readthedocs.io
14 stars 16 forks source link

Implementation of ePSF and astrometry fix #156

Closed gmzsebastian closed 2 years ago

gmzsebastian commented 2 years ago

This pull request is intended to be for the STIPS 2.0 release, implementing a number of changes. Mainly, the implementation of an ePSF routine that fixes previous astrometry issues. Other changes include:

Closes #155 Closes #142 Closes #141 Closes #134 Closes #130 Closes #129 Closes #128 Closes #111 Closes #110

york-stsci commented 2 years ago

I'm going to take a look at the environment.yml file, and see if I can figure out what's going on, because it seems as if the checks are failing more or less entirely because the environment isn't building for some reason.

york-stsci commented 2 years ago

The CI test failures with python 3.7 are part of removing python 3.7 support from STIPS version 2.0 I will file a cleanup PR that removes outdated tests. As such, and because the testing under python 3.8 succeeds both on GitHub and locally, I approve this PR.

The above is also a waiver for requiring passing CI tests for this particular PR. Note that STIPS will still need to have a clean set of tests for the 2.0.0 release.