Closed gmzsebastian closed 6 months ago
Hello @gmzsebastian, thank you for your work in this PR. I've addressed most of the findings of my code review in gmzsebastian/STScI-STIPS#6, so please check it out. Other than that, I have a few questions:
CHANGES.rst
here with entries for 2.2.0? These should include the upgraded minimum versions of Pandeia (and Python, if you accept gmzsebastian/STScI-STIPS#6).webbpsf==1.1.0
exactly or is it possible to work with any of the newer versions? RSP would probably appreciate the flexibility in the latter case, but I don't think it should delay the v2.2.0 release if not.master
to main
to bring it in line with other repositories in the ST/astropy universe? I don't think that action is technically linked to the release, so I can do it after the release is over if you agree.Thanks for merging my pull request. What do you think about the questions in my last comment here? (And about the possibility of listing a number for how much less accurate the fast_galaxy
scenario is in the examples.rst
?) I believe we're ready for a merge once those have been addressed.
This pull requests includes a number of bug fixed and improvements to STIPS for its 2.2 release, including: