spacetelescope / STScI-STIPS

STScI-STIPS
https://stips.readthedocs.io
14 stars 16 forks source link

STIPS 2.2 Pull Request #175

Closed gmzsebastian closed 6 months ago

gmzsebastian commented 6 months ago

This pull requests includes a number of bug fixed and improvements to STIPS for its 2.2 release, including:

ojustino commented 6 months ago

Hello @gmzsebastian, thank you for your work in this PR. I've addressed most of the findings of my code review in gmzsebastian/STScI-STIPS#6, so please check it out. Other than that, I have a few questions:

ojustino commented 6 months ago

Thanks for merging my pull request. What do you think about the questions in my last comment here? (And about the possibility of listing a number for how much less accurate the fast_galaxy scenario is in the examples.rst?) I believe we're ready for a merge once those have been addressed.