spacetelescope / acs-notebook

Python Jupyter Notebooks that support users of the ACS instrument on board the Hubble Space Telescope
http://www.stsci.edu/hst/acs
14 stars 13 forks source link

POC: Use AWS S3 buckets #22

Open pllim opened 5 years ago

pllim commented 5 years ago

DO NOT MERGE

This is part of the work for https://jira.stsci.edu/browse/JUSI-8 by DATB.

Blocked by:

cc @stscicrawford

nmiles2718 commented 5 years ago

Too much unnecessary cruft here. All that needs to be done is for the user to execute Observations.enable_cloud_dataset() in a cell proceeding the call to download found observations. No need for all the intermediate steps. Note that if we want to list this option for the user, we will need to do some more work to ensure that they have boto3 properly configured.

Screen Shot 2019-03-29 at 10 52 06 AM
pllim commented 5 years ago

@nmiles2718 , thank you very much for the review, which definitely cleaned things up. I think I have addressed your comment.