spacetelescope / acsql

The Advanced Camera for Surveys Quicklook Project
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Small database fixes #27

Closed bourque closed 7 years ago

bourque commented 7 years ago

This pull requests fixes a few small issues regarding the database and ingestion process:

  1. More precision on float types. Values such as MJD values will now have the full precision as found in the header.
  2. Changes instances of hyphens in database column names to underscores, making it easier to query using Python.
  3. Simplified make-jpeg to use np.percentile.
  4. Switching the path column in the master table to only store relative path within filesystem instead of the absolute path as to hide internal filesystem structure. The absolute path can be determined by acsql.utils.utils.SETTINGS['filesystyem']

Closes #20 and #26

pep8speaks commented 7 years ago

Hello @bourque! Thanks for submitting the PR.

Line 400:9: E128 continuation line under-indented for visual indent

Line 37:1: E265 block comment should start with '# ' Line 60:78: E502 the backslash is redundant between brackets Line 61:13: E128 continuation line under-indented for visual indent Line 66:17: E128 continuation line under-indented for visual indent Line 73:80: E501 line too long (82 > 79 characters)

Line 141:9: E128 continuation line under-indented for visual indent Line 142:13: E127 continuation line over-indented for visual indent Line 171:9: E128 continuation line under-indented for visual indent Line 172:13: E127 continuation line over-indented for visual indent Line 237:9: E128 continuation line under-indented for visual indent Line 238:13: E127 continuation line over-indented for visual indent

Line 82:9: E722 do not use bare except' Line 83:68: E502 the backslash is redundant between brackets Line 84:17: E128 continuation line under-indented for visual indent Line 89:64: E502 the backslash is redundant between brackets Line 90:13: E128 continuation line under-indented for visual indent Line 125:78: E502 the backslash is redundant between brackets Line 126:17: E128 continuation line under-indented for visual indent Line 136:76: E502 the backslash is redundant between brackets Line 137:17: E128 continuation line under-indented for visual indent Line 143:54: E502 the backslash is redundant between brackets Line 144:9: E128 continuation line under-indented for visual indent Line 199:55: E502 the backslash is redundant between brackets Line 200:25: E128 continuation line under-indented for visual indent Line 207:55: E128 continuation line under-indented for visual indent Line 231:19: E127 continuation line over-indented for visual indent

Line 79:48: E502 the backslash is redundant between brackets Line 80:13: E128 continuation line under-indented for visual indent

Line 61:80: E501 line too long (84 > 79 characters) Line 62:80: E501 line too long (90 > 79 characters) Line 64:80: E501 line too long (88 > 79 characters) Line 65:80: E501 line too long (92 > 79 characters) Line 98:80: E501 line too long (84 > 79 characters) Line 183:67: E502 the backslash is redundant between brackets Line 184:13: E128 continuation line under-indented for visual indent Line 184:40: E502 the backslash is redundant between brackets Line 186:58: E502 the backslash is redundant between brackets Line 187:13: E128 continuation line under-indented for visual indent Line 187:40: E502 the backslash is redundant between brackets Line 189:61: E502 the backslash is redundant between brackets Line 190:13: E128 continuation line under-indented for visual indent Line 190:50: E502 the backslash is redundant between brackets Line 223:80: E501 line too long (103 > 79 characters) Line 224:80: E501 line too long (98 > 79 characters) Line 281:80: E501 line too long (116 > 79 characters) Line 287:80: E501 line too long (117 > 79 characters) Line 288:80: E501 line too long (136 > 79 characters) Line 296:80: E501 line too long (154 > 79 characters) Line 298:80: E501 line too long (154 > 79 characters) Line 301:80: E501 line too long (86 > 79 characters) Line 302:80: E501 line too long (93 > 79 characters) Line 303:80: E501 line too long (89 > 79 characters) Line 306:80: E501 line too long (103 > 79 characters) Line 336:80: E501 line too long (116 > 79 characters) Line 340:80: E501 line too long (142 > 79 characters) Line 368:80: E501 line too long (83 > 79 characters) Line 376:80: E501 line too long (82 > 79 characters) Line 378:80: E501 line too long (98 > 79 characters) Line 379:9: E128 continuation line under-indented for visual indent Line 379:80: E501 line too long (99 > 79 characters) Line 381:9: E128 continuation line under-indented for visual indent Line 381:80: E501 line too long (99 > 79 characters)

Line 21:5: E128 continuation line under-indented for visual indent Line 22:5: E128 continuation line under-indented for visual indent Line 22:80: E501 line too long (80 > 79 characters) Line 23:5: E128 continuation line under-indented for visual indent Line 23:80: E501 line too long (83 > 79 characters) Line 24:5: E128 continuation line under-indented for visual indent Line 25:5: E128 continuation line under-indented for visual indent Line 25:80: E501 line too long (81 > 79 characters) Line 26:5: E128 continuation line under-indented for visual indent Line 26:80: E501 line too long (85 > 79 characters) Line 27:5: E128 continuation line under-indented for visual indent Line 28:19: E231 missing whitespace after ',' Line 28:25: E231 missing whitespace after ',' Line 30:5: E128 continuation line under-indented for visual indent Line 31:5: E128 continuation line under-indented for visual indent Line 32:5: E128 continuation line under-indented for visual indent Line 34:5: E128 continuation line under-indented for visual indent Line 35:5: E128 continuation line under-indented for visual indent Line 36:5: E128 continuation line under-indented for visual indent Line 37:5: E128 continuation line under-indented for visual indent Line 40:30: E231 missing whitespace after ',' Line 40:55: E231 missing whitespace after ',' Line 41:5: E128 continuation line under-indented for visual indent Line 41:21: E231 missing whitespace after ',' Line 41:51: E231 missing whitespace after ',' Line 42:16: E231 missing whitespace after ',' Line 42:46: E231 missing whitespace after ',' Line 42:73: E231 missing whitespace after ',' Line 42:80: E501 line too long (84 > 79 characters) Line 43:15: E231 missing whitespace after ',' Line 43:39: E231 missing whitespace after ',' Line 43:64: E231 missing whitespace after ',' Line 44:16: E231 missing whitespace after ',' Line 44:52: E231 missing whitespace after ',' Line 45:16: E231 missing whitespace after ',' Line 45:43: E231 missing whitespace after ',' Line 45:69: E231 missing whitespace after ',' Line 45:80: E501 line too long (83 > 79 characters) Line 46:15: E231 missing whitespace after ',' Line 46:47: E231 missing whitespace after ',' Line 47:16: E231 missing whitespace after ',' Line 47:67: E231 missing whitespace after ',' Line 47:80: E501 line too long (85 > 79 characters) Line 48:26: E231 missing whitespace after ',' Line 48:48: E231 missing whitespace after ',' Line 48:70: E231 missing whitespace after ',' Line 48:80: E501 line too long (84 > 79 characters) Line 50:5: E128 continuation line under-indented for visual indent Line 51:5: E128 continuation line under-indented for visual indent Line 63:80: E501 line too long (88 > 79 characters)