spacetelescope / astronify

Astronomical data sonification.
https://astronify.readthedocs.io
71 stars 15 forks source link

Why does sonification not work if only two values present? #42

Closed scfleming closed 3 years ago

scfleming commented 3 years ago

For transit simulator or case of top of square (e.g., square wave) the output sound isn't as expected. One would expect two distinct sounds at roughly 1/3 and 2/3 the allowed tone range, but instead it is basically monotone. This could be a bug, or could be result of algorithm being used, will investigate.

scfleming commented 3 years ago

This was mostly user error (bad choice to rely on default params in simulated case of two values only). Also changed pitch range without updating center pitch (code now protects against this inside pitch_mapper() just in case).