spacetelescope / astronify

Astronomical data sonification.
https://astronify.readthedocs.io
73 stars 15 forks source link

Updated simulator notebook, fix for single pitch, protections for bad conditions. #44

Closed scfleming closed 3 years ago

scfleming commented 3 years ago

This PR:

scfleming commented 3 years ago

@ceb8 I updated the .pynb but don't know the steps to convert to HTML for RTD (do you just run nbconvert on them?) Would you be able to take care of that part?

ceb8 commented 3 years ago

@scfleming This looks great! I'm going to run the ipynb->rst before merging. Unfortunately right now it's more manual than I would like.

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (a65ffc2) into main (e74802a) will decrease coverage by 0.39%. The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   67.44%   67.05%   -0.40%     
==========================================
  Files          16       16              
  Lines         341      346       +5     
==========================================
+ Hits          230      232       +2     
- Misses        111      114       +3     
Impacted Files Coverage Δ
astronify/series/series.py 77.95% <0.00%> (ø)
astronify/simulator/sim_lc.py 44.26% <0.00%> (ø)
astronify/utils/pitch_mapping.py 93.47% <66.66%> (-6.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e74802a...a65ffc2. Read the comment docs.

ceb8 commented 3 years ago

@scfleming Remember to clear the output before commiting jupyter notebooks. (I'm going to deal with it by squashing when I merge this PR).

scfleming commented 3 years ago

Oh, I thought it needed to be there so nbconvert would display things like the plots in the rendered HTML. My bad.

ceb8 commented 3 years ago

Thanks @scfleming !