spacetelescope / calcos

Calibration for HST/COS.
https://hst-docs.stsci.edu/cosdhb/chapter-3-cos-calibration
3 stars 27 forks source link

CalCOS Unit Tests -- cosutil, extract, airglow, average #182

Closed asfaw-michael closed 2 years ago

asfaw-michael commented 3 years ago

Written some tests for the functions in extract.py and cosutil.py

Rplesha commented 2 years ago

Remove tests/init.py from git

git rm tests/__init__.py

Rplesha commented 2 years ago

There are still a lot of changes to the calcos scripts (spacing, etc).

Try doing: git checkout origin/master <filename>

where is any of the names of the calcos files such as airglow.py. If this doesn't make it so that those files don't appear changed on this commit, we may need to brainstorm tomorrow.

Rplesha commented 2 years ago

@stscirij I believe this is ready to merge if you concur. It seems like there might be some issues from the readthedocs still that aren't letting it be merged, however.

stscirij commented 2 years ago

@rplesha I think the latest pushes to the master branch fix these problems. They won't stop merging the code, only the lack of a review stands in the way

stscirij commented 2 years ago

@rplesha is this going to be part of the LP6 build?

Rplesha commented 2 years ago

@asfaw-michael can you merge master into this branch to pull down the changes Robert is talking about? git checkout master git pull origin master git checkout pytest git pull origin pytest git merge master git push origin pytest

should do the trick

Rplesha commented 2 years ago

@stscirij I think the LP6 build is a good place for this to get merged in if you agree! There is a minor change to the calcos code itself. We'll need to change this request from master to your branch, but I think that's something we can do.

We should also establish a process of how we want to merge future unit tests, too! Currently, Michael is going to work on smaller branches so it's less of a huge item merging them all at once.

stscirij commented 2 years ago

These changes were incorporated into #205