spacetelescope / calcos

Calibration for HST/COS.
https://hst-docs.stsci.edu/cosdhb/chapter-3-cos-calibration
3 stars 27 forks source link

Fix issue #224: calcos bug when more than 2 wavecals #225

Closed stscirij closed 1 year ago

stscirij commented 1 year ago

This PR fixes #224, also corrects the units for the error_lower in the x1dsum file from count/s to erg/cm^2/sec/Angstrom.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.46 :tada:

Comparison is base (0bc435f) 87.17% compared to head (05c988b) 87.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #225 +/- ## ========================================== + Coverage 87.17% 87.63% +0.46% ========================================== Files 17 17 Lines 1333 1391 +58 ========================================== + Hits 1162 1219 +57 - Misses 171 172 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `87.63% <ø> (+0.46%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#carryforward-flags-in-the-pull-request-comment) to find out more. [see 6 files with indirect coverage changes](https://app.codecov.io/gh/spacetelescope/calcos/pull/225/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.