spacetelescope / calcos

Calibration for HST/COS.
https://hst-docs.stsci.edu/cosdhb/chapter-3-cos-calibration
3 stars 27 forks source link

Revert "move build configuration into `pyproject.toml` (#216)" #229

Closed zacharyburnett closed 1 year ago

zacharyburnett commented 1 year ago

This reverts commit 9af631fa0c0dcf475b0bbcc59545b2c81a2468d8 due to suspected involvement in https://jira.stsci.edu/browse/SPB-1432

It appears that the HCALDP build was explicitly relying on calcos to provide pytest as a dependency, and since calcos's metadata is not parsed correctly for some reason, and the only difference seems to be using PEP621 (setup.py -> pyproject.toml), we are reverting the PEP621 change for now.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (38dbf69) 87.63% compared to head (51a3440) 87.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #229 +/- ## ======================================= Coverage 87.63% 87.63% ======================================= Files 17 17 Lines 1391 1391 ======================================= Hits 1219 1219 Misses 172 172 ``` | Flag | Coverage Δ | | |---|---|---| | unit | `87.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=spacetelescope#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

zacharyburnett commented 1 year ago

Hopefully this resolves the issue. After merging this PR we'll have to start the HCALDP job again and then we'll see

stscirij commented 1 year ago

Will try and fix the readthedocs build error in the next PR