spacetelescope / catkit2

Package for controlling testbed hardware.
https://spacetelescope.github.io/catkit2/
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Value on datastream for datastream-backed property #116

Open ehpor opened 1 year ago

ehpor commented 1 year ago

https://github.com/spacetelescope/catkit2/blob/295a07bd62b5960b3f569b517c08225e3397500a/catkit_core/Property.cpp#L81

Sometimes setter will not set their internal value to the requested value, but something very close. In this case, Datastream-backed properties will still put the requested value on the datastream, leading to that value being retrieved the next time the getter is called. Instead of the requested value, we should call the getter right after the setter in the code above, and put that value on the datastream rather than the requested one.

FYI: @asahooexo

raphaelpclt commented 3 weeks ago

Little bit of C++.