Closed erinpougheon closed 3 months ago
First of all, I had a "problem" while trying to connect the camera to the PC to run tests. Python code wasn't able to detect the camera, even though it was connected well to the PC. We discovered that it was due to the driver. We needed to go through NI MAX to change the Allied Vision Camera driver so we could control it though Python. Here is a picture of NI MAX to remember how to change the driver :
I added a sentence in the Allied Vision Camera service documentation saying that the camera needs the proper driver to be able to run under the service.
I ran some tests on the Allied Vision Camera in the corono room to determine which properties need the acquisition to stop to be changed :
So, with inspiration from the FLIR camera, I changed the way properties are created, so they can all be changed without having to stop mannualy the acquisition. I ran some tests to verity, and they were successful, I was able to change width, height, offset_x, offset_y (and gain, exposure_time) without having to stop the service. However, I still have the same probelm with the brightness, the service didn't recognize it. I think that "brightness" may have another name that could be recognized, but I need to figure out which one.
Looks good to me! @erinpougheon please remind me, did you test this on hardware yet? I think so, just wanted to confirm.
Btw the failing test is not due to your changes. We might have to get someone like @raphaelpclt in the loop to figure out what is happening there, I am not entirely sure I understand it.
Looks good to me! @erinpougheon please remind me, did you test this on hardware yet? I think so, just wanted to confirm.
Btw the failing test is not due to your changes. We might have to get someone like @raphaelpclt in the loop to figure out what is happening there, I am not entirely sure I understand it.
Yes, I ran some tests on an Allied Vision Camera in the corono room last week. Since the only changes are in the documentation, the tests are still valid I think !
Great, then I will go ahead and approve.
I'll ping the RMOL folks when they start waking up to ask about the failing CI test.
Just re-ran the test that failed, and... it worked :) Don't know what happened, but you're good to go @erinpougheon
Thanks a lot @raphaelpclt!
Fix #183.
Changing the Allied Vision Camera service so we will be able to change certain properties without having to stop the acquisition.