search

spacetelescope / catkit2

Package for controlling testbed hardware.
https://spacetelescope.github.io/catkit2/
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Fix testbed port numbers #239

Closed ehpor closed 2 months ago

ehpor commented 2 months ago

Testbed port numbers were hardcoded in some places. This PR fixes that.

Fixes #240 Required for #204

ivalaginja commented 1 week ago

@ehpor were there any changes necessary for this on hicat-package2? When running on a catkit2 version that includes this PR, I get errors for thd-controls when running trying to start the server hardware (not the actual THD2 PC but an adjacent one) but not in simulation (on my Mac, and Axel's). I'll need to go retrieve the exact error message.

ehpor commented 1 week ago

I don't think so. But I'll check soon. The error message would be helpful.

Maybe some of the GUI elements?

johanmazoyer commented 1 week ago

This is the error we are getting on Windows 10, on hardware. It happens when launching server. Screenshot 2024-10-29 at 17 29 41

ehpor commented 1 week ago

Did you recompile catkit2 after pulling the latest update?

ivalaginja commented 1 week ago

Definitely not. Let me do that and try again...

ivalaginja commented 1 week ago

Problem solved, thanks @ehpor.