Closed kassin closed 5 years ago
I'll go through this list and check things.
Here are my testing notes on v0.1.dev540, following the items in #257
UPDATED based on v.558. I crossed out things which work now, thanks :smile: Items in bold are things I think are most important to get cubeviz usable now. The other things are just nice additions. @kassin @brechmos-stsci
Load your favorite datasets
Spatial smoothing
Spectral smoothing
The smoothing kernel needs units. I think it's currently pixels but I'm not sure...
It would be great to have an option to plot a smoothed spectrum weighted by the inverse variance (from the noise cube). This is useful to smooth out bright skylines in near-IR observations
Cube collapsing over wavelength ranges
Basic image control (moving through slices, overlays etc)
Would it be possible to show 2D ROIs as a contour? I.e. have the option to show only the edges rather than the whole ROI
Under contour options show the default parameters (at the moment everything is = 0)
~Hovering over 2D viewer, pixel values (\~1E-20) show as 0.000 --> need to display in scientific notation~
CKJ: Hot keys a, d, f and p work for me
Interaction with 1D spectra functionality
Save calculated data
@kassin can this issue be closed?
Not until Charlotte & I are able to run our use cases through CubeViz.
From @kassin's comments above. These are all fixed, worked or I created an issue.
Region selection doesn't work with the MaNGA cube I've loaded.
Can select a ROI in SpecViz, but cannot Apply to Cube.
Data Processing -> Collapse Cube doesn't seem to do anything.
"a" and "d" hot keys don't change the slice displayed.
"f" for freezing doesn't seem to work. same for "p" for pull
When I have a dialog box displayed and I click outside of glue, the box disappears. Whenn I click back in glue, it appears again.
View -> Wavelength Units: When I change the units the spectrum display shows a super large range, including wavelengths where there are no data. Also, this causes the the IVAR and MASK cubes to rescale so that they are both all black. Same thing happens if I choose other options in this menu other than Angstroms.
If I choose mm, the spectrum disappears entirely.
View -> RA - Spectral and DEC - Spectral don't seem to do anything.
Data Processing -> Arithmetic Operation TEST2 = FLUX + 100 However, the spectrum doesn't seem to reflect this change.
The Save Dialog box makes it looks like I will overwrite the currently loaded cube. Phew, I hit "OK" and see this is not the case now. The saved file has no suffix if I don't type one. Perhaps we should automatically append one?
If I save a single smoothed component (as a single componet cube with no ivar or mask) and read it into a fresh glue session, it loads the component in all three viewers. It should only display it in one viewer.
Unable to save session. The error is: "Failed to save session Don't know how to serialize <cubeviz.data_factories.DataConfiguration object at 0x18335e6748> of type <class 'cubeviz.data_factories.DataConfiguration'>"
Smoothing
"Info: Smoothing previews are displayed on CubeViz's left and single image viewers." Since we will eventually allow the users to move the viewers around, and some users may be unsure about what the single image viewer is, hwo about stating something like this instead: "A preview of the smoothing operation is displayed in Viewer 1."
We need to state somewhere that the preview smooths the one channel displayed, and clicking on "okay" smooths the entire cube.
Contours
Viewer Options
scaling (ie slider bar next to "color/opacity) in the viewer options panel) shouldn't bee linked across the 3 viewers as a default
I can't think of a use case where one would want to scale the 3 viewers at the same time, so perhaps remove the "sync" button.
For playing movie to run through channels, can I change the speed?
The "limits" in "Plot Options - 2D Image" don't seem useful since they don't correspond to the limits shown on the image.
If I change the limits, I cannot undo it using the Edit -> Undo option.
From @charlottenosam's comments above:
Load your favorite datasets KMOS cubes only have 2 extensions (data + noise) but the loader loads 3 views (1x data + 2x noise). It would make sense to leave the 3rd viewer blank if there is so extension
The smoothing kernel needs units. I think it's currently pixels but I'm not sure...
It would be great to have an option to plot a smoothed spectrum weighted by the inverse variance (from the noise cube). This is useful to smooth out bright skylines in near-IR observations
Cube collapsing over wavelength ranges Worked fine, though it would be nice if the smoothed cube appeared automatically in one of the viewers
Basic image control (moving through slices, overlays etc)
Would it be possible to show 2D ROIs as a contour? I.e. have the option to show only the edges rather than the whole ROI
C: it should show the whole ROI
Under contour options show the default parameters (at the moment everything is = 0)
C: This does have proper default parameters
Hovering over 2D viewer, pixel values (~1E-20) show as 0.000 --> need to display in scientific notation
C: they are now in scientific notation
Interaction with 1D spectra functionality
It isn't possible to change flux units
C: Works now...
I still can't see a line showing which wavelength position the 2D viewer is at
C: this works
When hovering can you show the wavelength pixel as well as physical units?
this works (if there are units in the input file)
If you drag an ROI in specviz which was already linked to a cubeviz viewer component to a new wavelength position, I think that the 2D viewer should move automatically to the new position.
C: Once a collapsed cube is created from a spectral region, by design, the cube is not updated. If this is desired, then we will have to work on it (@hcferguson @kassin)
Save calculated data
At the moment unless you type the file extension it doesn't add one (might be a MacOS High Sierra thing)
C: I believe that is a glue thing but will discuss with @astrofrog
I don't understand what saving a subset does. I thought it might zero all the flux outside the ROI for example, but it didn't seem to do anything.
C: It does seem to save a FITS file (if fits is selected), but the extension is missing, as noted above.
You can save the 2D viewers as images, is it also possible to save them as 2D fits files?
C: Saving appears to work (though must specify the extension)
Can you save 1D spectra from specviz as fits/txt AND as images?
C: I don't see how to and the export button doesn't seem to do anything, opened a SpecViz ticket https://github.com/spacetelescope/specviz/issues/685
Discussed with @hcferguson and we are good to close this.
(Apologies in advance if some of these features are not supposed to work yet.)
v0.1.dev534
Region selection doesn't work with the MaNGA cube I've loaded.
Can select a ROI in SpecViz, but cannot Apply to Cube.
Data Processing -> Collapse Cube doesn't seem to do anything.
"a" and "d" hot keys don't change the slice displayed. "f" for freezing doesn't seem to work. same for "p" for pull
When I have a dialog box displayed and I click outside of glue, the box disappears. Whenn I click back in glue, it appears again.
View -> Wavelength Units: When I change the units the spectrum display shows a super large range, including wavelengths where there are no data. Also, this causes the the IVAR and MASK cubes to rescale so that they are both all black. Same thing happens if I choose other options in this menu other than Angstroms.
If I choose mm, the spectrum disappears entirely.
View -> RA - Spectral and DEC - Spectral don't seem to do anything.
Data Processing -> Arithmetic Operations TEST2 = FLUX + 100 However, the spectrum doesn't seem to reflect this change.
The Save Dialog box makes it looks like I will overwrite the currently loaded cube. Phew, I hit "OK" and see this is not the case now. The saved file has no suffix if I don't type one. Perhaps we should automatically append one?
If I save a single smoothed component (as a single componet cube with no ivar or mask) and read it into a fresh glue session, it loads the component in all three viewers. It should only display it in one viewer.
Unable to save session. The error is: "Failed to save session Don't know how to serialize <cubeviz.data_factories.DataConfiguration object at 0x18335e6748> of type <class 'cubeviz.data_factories.DataConfiguration'>"
Smoothing
-"Info: Smoothing previews are displayed on CubeViz's left and single image viewers." Since we will eventually allow the users to move the viewers around, and some users may be unsure about what the single image viewer is, hwo about stating something like this instead: "A preview of the smoothing operation is displayed in Viewer 1."
-We need to state somewhere that the preview smooths the one channel displayed, and clicking on "okay" smooths the entire cube.
Contours
-Perhaps change "Custom Component" to "Other Component" because custom implies that the user can create this component somehow.
Viewer Options
-scaling (ie slider bar next to "color/opacity) in the viewer options panel) shouldn't bee linked across the 3 viewers as a default
-I can't think of a use case where one would want to scale the 3 viewers at the same time, so perhaps remove the "sync" button.
-For playing movie to run through channels, can I change the speed?
-The "limits" in "Plot Options - 2D Image" don't seem useful since they don't correspond to the limits shown on the image.
-If I change the limits, I cannot undo it using the Edit -> Undo option.
@brechmos-stsci @drdavella @astrofrog @robelgeda @javerbukh