drdavella commented 5 years ago

~We still rely on astropy_helpers to generate a version.py file, but instead of including it as a submodule we now put it in setup_requires and in pyproject.toml.~

codecov[bot] commented 5 years ago

Codecov Report

Merging #492 into master will decrease coverage by 0.14%. The diff coverage is 58.62%.

@@            Coverage Diff            @@
##           master    #492      +/-   ##
=========================================
- Coverage   62.34%   62.2%   -0.15%     
=========================================
  Files          43      40       -3     
  Lines        5088    5069      -19     
=========================================
- Hits         3172    3153      -19     
  Misses       1916    1916

Impacted Files	Coverage Δ
cubeviz/_internal_init.py	`40.74% <47.36%> (-11.54%)`	:arrow_down:
cubeviz/__init__.py	`83.33% <80%> (-16.67%)`	:arrow_down:
cubeviz/cubeviz.py	`18.33% <0%> (-13.34%)`	:arrow_down:
cubeviz/conftest.py	`82.85% <0%> (+5.71%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8e4c24...d15e225. Read the comment docs.

drdavella commented 5 years ago

I'm going to argue that the coverage report is not particularly relevant for this PR.

brechmos-stsci commented 5 years ago

Agreed that the code coverage failures aren't relevant for this PR.

spacetelescope / cubeviz

Overhaul package infrastructure to use modern practices #492

Codecov Report