search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Version import fixes #494

Closed astrofrog closed 5 years ago

astrofrog commented 5 years ago

The version import doesn't work anymore now that setuptools_scm is used. Also removed a glue file which appeared.

astrofrog commented 5 years ago

I'm a little puzzled as to how the tests passed before, but I don't have time to investigate today.

codecov[bot] commented 5 years ago

Codecov Report

Merging #494 into master will increase coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage    62.2%   62.31%   +0.11%     
==========================================
  Files          40       40              
  Lines        5069     5069              
==========================================
+ Hits         3153     3159       +6     
+ Misses       1916     1910       -6
Impacted Files Coverage Δ
cubeviz/conftest.py 77.14% <100%> (-5.72%) :arrow_down:
cubeviz/cubeviz.py 31.66% <100%> (+13.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5aa9c2...d582830. Read the comment docs.

drdavella commented 5 years ago

Just putting a comment here for posterity: we don't actually call cubeviz.main to start cubeviz in the test suite. Instead, we use a test fixture that constructs a cubeviz application instance in a slightly different way (since we don't need to process command-line arguments or show the splash screen.

We should probably refactor this so that the tests share more code with the way users run the application.