search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Refactor app initialization to enable better testing #495

Closed drdavella closed 5 years ago

drdavella commented 5 years ago

These changes allow the test fixture to overlap more with the code path executed by users when running the application from the command line. This would have allowed the bug fixed in #494 to have been caught by automated tests.

codecov[bot] commented 5 years ago

Codecov Report

Merging #495 into master will increase coverage by 0.4%. The diff coverage is 56.86%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #495     +/-   ##
=========================================
+ Coverage   63.76%   64.16%   +0.4%     
=========================================
  Files          39       39             
  Lines        4945     4956     +11     
=========================================
+ Hits         3153     3180     +27     
+ Misses       1792     1776     -16
Impacted Files Coverage Δ
cubeviz/tests/helpers.py 100% <100%> (ø) :arrow_up:
cubeviz/cubeviz.py 63.88% <54.16%> (+32.22%) :arrow_up:
cubeviz/data_factories/__init__.py 70.17% <0%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfcaca3...88eba33. Read the comment docs.

drdavella commented 5 years ago

Since this is a refactoring without any new functionality or bug fixes I'm going to argue that the coverage results here are not particularly relevant.