Image Viewer tests: Fast slider tests

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

15 stars 25 forks source link

Image Viewer tests: Fast slider tests #510

Closed SaOgaz closed 5 years ago

SaOgaz commented 5 years ago

Part of #394

javerbukh commented 5 years ago

How is this different from test_fast_slider_indexing in cubeviz/cubeviz/tests/test_ui.py, line 258? @brechmos-stsci @drdavella

drdavella commented 5 years ago

It's possible that the existing test already addresses this so the issue can be closed. However, it seems like it would also be useful to have a test that calls fast_draw_slice_index in cubeviz/image_viewer.py.

javerbukh commented 5 years ago

Ok, since part of this issue is solved, I will put this at a lower priority than the other pytest issues. I will get back to this if time allows.

drdavella commented 5 years ago

While the function fast_draw_slice_index is not called directly in any tests, according to codecov it appears to be covered by the test suite (see here), so I'm closing this issue.