search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Updates to make cubeviz pip-installable #516

Closed drdavella closed 5 years ago

drdavella commented 5 years ago

This adds pyqt5 to install_requires so it does not need to be installed by conda. It also addresses the issue that occurs on some OSX machines where matplotlib complains about Python not being installed as a framework.

codecov[bot] commented 5 years ago

Codecov Report

Merging #516 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   63.69%   63.75%   +0.05%     
==========================================
  Files          39       39              
  Lines        4942     4944       +2     
==========================================
+ Hits         3148     3152       +4     
+ Misses       1794     1792       -2
Impacted Files Coverage Δ
cubeviz/__init__.py 85.71% <100%> (+2.38%) :arrow_up:
cubeviz/layout.py 82.89% <100%> (ø) :arrow_up:
cubeviz/keyboard_shortcuts.py 48.07% <0%> (+3.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39f542d...a624c4c. Read the comment docs.

drdavella commented 5 years ago

Needed to make one update to get the (allowed-to-fail) Windows test passing. But now it works and since it's been reviewed and tests are passing, I'm merging.