spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Units in MANGA file #537

Closed hcferguson closed 3 years ago

hcferguson commented 5 years ago

Cubeviz complains about the units in the MANGA test dataset: /astro/3/jwst_da_sprint_testdata/IFU_datacubes/manga-7495-12704-LOGCUBE.fits.gz.

Failed to add subset
'1E-17 erg/s/cm^2/Ang/spaxel' did not parse as unit: At col 17, Ang is not a valid unit. Did you mean aG, aN, ag, nG or ng?

There are various sub-issues here:

brechmos-stsci commented 5 years ago

This is something new that just started coming up after the cubeviz-specviz integration, though 'Ang' is not a valid unit. The question, I believe is coming from astropy.units (https://github.com/astropy/astropy/blob/de3933688433e22765b1bdffa175fcd954d691c3/astropy/units/format/utils.py#L152) so it is not a cubeviz specific question.

A couple possible solutions:

Either way we probably need to catch that warning/question so it is not printed at all.

drlaw1558 commented 5 years ago

Longer term I'll change the MaNGA data format to 'Angstrom' instead of 'Ang', but this won't impact publicly-available data for ~ 18 months.

drlaw1558 commented 5 years ago

Done!