search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Overlay unit tests #544

Closed javerbukh closed 5 years ago

javerbukh commented 5 years ago

Overlay tests created, however they are interfering with tests from test_ui.py. test_ui.py continuously checks whether the combo.count() equals a certain value, and by creating a moment map and changing overlays, my tests interfere with that count. Looking for how to proceed at this point.

Resolves #514

codecov[bot] commented 5 years ago

Codecov Report

Merging #544 into master will increase coverage by 1.16%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   58.92%   60.08%   +1.16%     
==========================================
  Files          26       26              
  Lines        4265     4267       +2     
==========================================
+ Hits         2513     2564      +51     
+ Misses       1752     1703      -49
Impacted Files Coverage Δ
cubeviz/tools/moment_maps.py 92.2% <100%> (+0.2%) :arrow_up:
cubeviz/layout.py 83.09% <0%> (+0.2%) :arrow_up:
cubeviz/listener.py 92.1% <0%> (+3.94%) :arrow_up:
cubeviz/controls/overlay.py 98.78% <0%> (+54.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97d4a31...f4bac83. Read the comment docs.