search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Image viewer contour tests #545

Closed javerbukh closed 5 years ago

javerbukh commented 5 years ago

Resolves #509

codecov[bot] commented 5 years ago

Codecov Report

Merging #545 into master will increase coverage by 7.33%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   60.86%   68.19%   +7.33%     
==========================================
  Files          26       26              
  Lines        4267     4267              
==========================================
+ Hits         2597     2910     +313     
+ Misses       1670     1357     -313
Impacted Files Coverage Δ
cubeviz/image_viewer.py 75.09% <0%> (+14.72%) :arrow_up:
cubeviz/utils/contour.py 76.24% <0%> (+55.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 160949a...8fa2c85. Read the comment docs.

drdavella commented 5 years ago

@javerbukh this needs to be rebased now.

drdavella commented 5 years ago

According to @brechmos-stsci, calling axes.get_children() on the underlying viewer will show a list that contains matplotlib.collection.LineCollection objects when the contour is displayed. These objects should not be present when the contour is not displayed, although there will be other children.