search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Update specviz data viewer explicitly to avoid message order issues #548

Closed nmearl closed 5 years ago

nmearl commented 5 years ago

The order of event calls in glue is sometimes inconsistent, resulting in issues when updating the vertical line slice indicator in specviz. This PR avoids this by calling changes directly. Requires spacetelescope/specviz#639.

codecov[bot] commented 5 years ago

Codecov Report

Merging #548 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   68.22%   68.23%   +<.01%     
==========================================
  Files          26       26              
  Lines        4268     4269       +1     
==========================================
+ Hits         2912     2913       +1     
  Misses       1356     1356
Impacted Files Coverage Δ
cubeviz/controls/wavelengths.py 96.92% <100%> (ø) :arrow_up:
cubeviz/layout.py 84.55% <100%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7d3af7...f97fc01. Read the comment docs.