search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 27 forks source link

Add integration tests for specviz #556

Closed drdavella closed 5 years ago

drdavella commented 5 years ago

This resolves #508. It is not currently possible to test flux unit changes since the canned test data we use does not appear to have flux units.

codecov[bot] commented 5 years ago

Codecov Report

Merging #556 into master will increase coverage by 0.77%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   60.08%   60.86%   +0.77%     
==========================================
  Files          26       26              
  Lines        4267     4267              
==========================================
+ Hits         2564     2597      +33     
+ Misses       1703     1670      -33
Impacted Files Coverage Δ
cubeviz/image_viewer.py 60.36% <0%> (+1.09%) :arrow_up:
cubeviz/layout.py 84.52% <0%> (+1.42%) :arrow_up:
cubeviz/controls/flux_units.py 66.12% <0%> (+2.18%) :arrow_up:
cubeviz/listener.py 94.73% <0%> (+2.63%) :arrow_up:
cubeviz/messages.py 87.09% <0%> (+12.9%) :arrow_up:
cubeviz/flux_equivalences.py 87.17% <0%> (+25.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd8a0c3...859f303. Read the comment docs.

drdavella commented 5 years ago

UPDATE: I've made it possible to test flux units as well and will be pushing more changes shortly.