search

spacetelescope / cubeviz

Data analysis package for cubes. https://cubeviz.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
15 stars 25 forks source link

Do not check primary HDU for valid CUNIT/CTYPE #560

Closed drdavella closed 3 years ago

drdavella commented 5 years ago

This resolves #559.

To clarify: we do not check the primary HDU for valid CUNIT/CTYPE unless the primary HDU contains a data array with three dimensions.

drdavella commented 5 years ago

To test whether it works, compare opening cubeviz/tests/data/data_cube.fits.gz both with and without this change.

codecov[bot] commented 5 years ago

Codecov Report

Merging #560 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   60.86%   60.86%           
=======================================
  Files          26       26           
  Lines        4267     4267           
=======================================
  Hits         2597     2597           
  Misses       1670     1670
Impacted Files Coverage Δ
cubeviz/data_factories/ifucube.py 73.38% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 160949a...2cdf99e. Read the comment docs.