Initial upload of NIRCam PSF-matched photometry notebook

spacetelescope / dat_pyinthesky

Notebooks for "notebook-driven development" for the Data Analysis Tools efforts

https://dat-pyinthesky.readthedocs.io/en/latest/

8 stars 44 forks source link

Initial upload of NIRCam PSF-matched photometry notebook #133

Closed dancoe closed 3 years ago

dancoe commented 3 years ago

Other changes and modified files can be ignored. Also, I've yet to include the file JADES_SF_mock_r1_v1.1.fits.gz here. It's 111.5 MB. I only need a small portion of it. I'll prepare that soon...

robelgeda commented 3 years ago

Hi Dan, Here is a check list on things that we need to have to start the review:

[ ] Box:
- [ ] Data has been uploaded to box.
- [ ] The data is bing shared via link. Make sure the settings allow for anyone with a link to download.
[ ] GitHub:
- [ ] Notebook has all cell outputs cleared out.
- [ ] Notebook is written in Python 3
- [ ] All imports occur at the beginning of the notebook.
- [ ] All data is loaded into the notebook via a URL from box. (No local files being used).
- [ ] Verify that the python code satisfies PEP 8.
- [ ] Comments and unused lines of code are removed.
- [ ] requirements.txt file is included.

hcferguson commented 3 years ago

Looks quite good. I agree it's a bit puzzling that the photometry doesn't look better. I'd suggest looking at compact bright sources and seeing if it is well-behaved for those.

I have a bunch of relatively minor comments I've put into an annotated version of the notebook (in blue). Seems I can't attach it here. I'll email it to @dancoe.

The most important comments are:

The workflow probably won't work if the long-wavelength images aren't resampled to the same pixel scale as the short wavelength images.
I'd suggest a bit more explanation of your approach to doing the PSF-matched photometry before you dive into it.
You should make sure your PSF kernels are normalized.

hcferguson commented 3 years ago

The revised version looks good to me!