search

spacetelescope / dat_pyinthesky

Notebooks for "notebook-driven development" for the Data Analysis Tools efforts
https://dat-pyinthesky.readthedocs.io/en/latest/
8 stars 44 forks source link

Spectral extraction tests #158

Closed ibusko closed 2 years ago

ibusko commented 2 years ago

This is in response to JDAT-1855: "Try already available specreduce functionality on JWST data".

The notebook relies on the kosmos package to build a trace object necessary to run specreduce's boxcar extraction code. It also uses a locally-fixed version of this code, where a bug was removed. Lastly, it has trouble in actually using the Spectrum1D instance created by the extraction code. This object has its wavelength attribute set in pixel units, which causes trouble with code downstream that wants to use it.

The notebook also uses boxcar-extraction code taken from another notebook, adapts and augments it to allow extractions from boths2d and s3d data, and exercises it with JWST simulated data.

Added on 12/08/2021: minimalist boxcar code based on numpy slices (good for rectified 2-D and 3-D data only).

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ojustino commented 2 years ago

@ibusko Since your notebook was approved in astropy/specreduce#79 and astropy/specreduce#82 on both scientific and technical bases, I'm going to close this pull request. It was said that we don't actually want to merge this notebook here in dat_pytinthesky.