search

spacetelescope / dat_pyinthesky

Notebooks for "notebook-driven development" for the Data Analysis Tools efforts
https://dat-pyinthesky.readthedocs.io/en/latest/
8 stars 44 forks source link

Lrsoptimal #167

Closed orifox closed 2 years ago

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ojustino commented 2 years ago

I'm closing this branch since spacetelescope/jdat_notebooks#91 is picking up where it left off. The merge conflicts are also no longer an issue there.

orifox commented 2 years ago

@ojustino Finally getting back to this! I realized that we also need to transfer the miri_lrs_spectra_extraction.ipynb notebook from this PR to the jdat_notebooks#91. There was a small, but very important, change. Can you help me with this when you have the chance.

ojustino commented 2 years ago

@orifox, I recommend submitting your changes to miri_lrs_spectral_extraction.ipynb as a separate pull request at jdat_notebooks.

For your reference, spacetelescope/jdat_notebooks#91 is dead; you should be doing the technical review for the specreduce notebook at spacetelescope/jdat_notebooks#93.