search

spacetelescope / dat_pyinthesky

Notebooks for "notebook-driven development" for the Data Analysis Tools efforts
https://dat-pyinthesky.readthedocs.io/en/latest/
8 stars 44 forks source link

Changed Titles in All Notebooks #176

Closed orifox closed 2 years ago

orifox commented 2 years ago

Changed titles in all notebooks for more consistency and resulting titles listed in rendered pages.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ojustino commented 2 years ago

I like the move to standardize more parts of the notebook creation process. I will leave my more detailed comments as reviews.

A more general one is that the format of these cells is a little inconsistent from notebook to notebook – sometimes the categories are double-spaced, sometimes certain ones share a line, etc. I usually consider this too pedantic for the technical reviews, but it may be worth addressing since you're already in the mode of editing all of these notebooks. It would also give more clarity to future technical reviewers.

orifox commented 2 years ago

Ok @ojustino and @pllim comments all addressed. Please merge.

pllim commented 2 years ago

I'll let @ojustino have one more look. Thanks!

ojustino commented 2 years ago

All of my specific comments were resolved, so I'll do the merge now.