search

spacetelescope / dat_pyinthesky

Notebooks for "notebook-driven development" for the Data Analysis Tools efforts
https://dat-pyinthesky.readthedocs.io/en/latest/
8 stars 44 forks source link

Fixed casing on argument to set_colormap. #190

Closed jfcarr closed 1 year ago

jfcarr commented 1 year ago

Passing 'viridis' as lowercase was causing the following error in the notebook:

ValueError: Invalid colormap 'viridis', must be one of ['Gray', 'Viridis', 'Plasma', 'Inferno', 'Magma', 'Purple-Blue', 'Yellow-Green-Blue', 'Yellow-Orange-Red', 'Red-Purple', 'Blue-Green', 'Hot', 'Red-Blue', 'Red-Yellow-Blue', 'Purple-Orange', 'Purple-Green', 'Reversed: Gray', 'Reversed: Viridis', 'Reversed: Plasma', 'Reversed: Inferno', 'Reversed: Magma', 'Reversed: Hot']

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rosteen commented 1 year ago

Hi @jfcarr, these notebooks are now being maintained at https://github.com/spacetelescope/jdat_notebooks. I can make this change over there if you want, or you can open a pull request to that repository. Just let me know (and thanks for the fix!).

jfcarr commented 1 year ago

Hi @jfcarr, these notebooks are now being maintained at https://github.com/spacetelescope/jdat_notebooks. I can make this change over there if you want, or you can open a pull request to that repository. Just let me know (and thanks for the fix!).

I thought I might be in the wrong repo. :) I'll open a new pull request over there, and thanks for letting me know!

rosteen commented 1 year ago

Great, thank you!

rosteen commented 1 year ago

Closing this, now at https://github.com/spacetelescope/jdat_notebooks/pull/114.