search

spacetelescope / drizzle

A package for combining dithered images into a single image
https://spacetelescope-drizzle.readthedocs.io/en/latest/
Other
51 stars 26 forks source link

Deprecate tophat kernel. Warn about flux not being conserved with some kernels #140

Closed mcara closed 9 months ago

mcara commented 9 months ago

This PR deprecates the "tophat" kernel which never worked correctly and adds warnings about some kernels ("gaussian" and "lanczos*") not conserving flux in the presence of distortions (non-linear terms) in input image WCS.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ab75714) 75.29% compared to head (1be97ff) 75.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #140 +/- ## ======================================= Coverage 75.29% 75.29% ======================================= Files 7 7 Lines 344 344 ======================================= Hits 259 259 Misses 85 85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mcara commented 9 months ago

JWST pipeline regression tests running here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1208/

mcara commented 9 months ago

There are 2 regtest failures that do not appear to be related to this PR.

perrygreenfield commented 9 months ago

While the code doesn't mention the issue of distortions regarding the validity of flux conservation, is it really true that it requires distortion to fail flux conservation.

mcara commented 9 months ago

While the code doesn't mention the issue of distortions regarding the validity of flux conservation, is it really true that it requires distortion to fail flux conservation.

Good question. Probably not.