search

spacetelescope / drizzle

A package for combining dithered images into a single image
https://spacetelescope-drizzle.readthedocs.io/en/latest/
Other
51 stars 26 forks source link

Use astropy pixel_to_pixel instead of internal calc_pixmap function #51

Open jdavies-st opened 4 years ago

jdavies-st commented 4 years ago

Use astropy.wcs.utils.pixel_to_pixel instead of

https://github.com/spacetelescope/drizzle/blob/291b8b6249f2b24cac801ea99b383f7bf61dd1aa/drizzle/calc_pixmap.py#L5

if possible.

This will require bumping up the astropy and other dependency versions.

mcara commented 1 month ago

Not sure what this is referring to but, with a soon to be released 2.0, this issue is no longer valid: the caller can use any method to create a pixel map.

jdavies-st commented 1 month ago

This issue is still valid. The calc_pixmap() function maintained here in Drizzle is a specialized version of the more general function in astropy

https://github.com/astropy/astropy/blob/92cf1d46dc165fc3e07fba373a7211b814560fbb/astropy/wcs/utils.py#L887

The functionality has moved upstream to Astropy and therefore Drizzle should use it.