spacetelescope / drizzlepac

AstroDrizzle for HST images.
https://drizzlepac.readthedocs.io
BSD 3-Clause "New" or "Revised" License
50 stars 39 forks source link

MVM: Removed hardcoded paths for catalogs/images in mvm_quality_analysis module #1415

Closed stscijgbot-hstdp closed 2 years ago

stscijgbot-hstdp commented 2 years ago

Issue HLA-803 was created on JIRA by Michele De La Pena:

In the mvm_quality_analysis.py module (locate_svm_products()), the catalogs and associated images needed to support cross-matching will only be found if they are stored in very specifically named local paths.  The module must be updated to be dynamic in the catalog search process.  Note for proper processing both the images and catalogs are needed.o

stscijgbot-hstdp commented 7 months ago

Comment by Michele De La Pena on JIRA:

No discovery needs to be done by the HAP code as this will be handled by the workflow in operations.  The files needed for analysis, filter-level DRZ/DRC and catalogs, once obtained by the operations workflow will reside in the current working directory.

stscijgbot-hstdp commented 7 months ago

Comment by Steve Goldman on JIRA:

Michele De La Pena Do you know if this issue has been addressed? If not, is this a file handling issue?

stscijgbot-hstdp commented 7 months ago

Comment by Michele De La Pena on JIRA:

Steve Goldman I do not believe this has been addressed.  As I recall the catalogs are expected to be located in certain directories at this time by the code.  However, all the files will be in the "main" directory once processing is done.  For MVM quality analysis to be done, the files should be present in the current working directory.  The paths used by the code need to be removed.

 

stscijgbot-hstdp commented 7 months ago

Comment by Steve Goldman on JIRA:

The relevant function is now named {_}locate_svmcatalogs(){}. It looks like the code is using the current directory os.getcwd(). I'm assuming that a fix would be to point the path to the main drizzlepac directory, so I will begin adding and testing that. 

stscijgbot-hstdp commented 7 months ago

Comment by Steve Goldman on JIRA:

It looks like the default directory while running the code is already the top level directory. That being the case, unless I'm missing something, this problem seems resolved.