Open stscijgbot-hstdp opened 2 years ago
Comment by Steve Goldman on JIRA:
Hey Zach, if you have already done this, please close the ticket.
Comment by Zach Burnett on JIRA:
made a (long overdue) PR at spacetelescope/fitsblender#45 (sorry for the delay!)
Issue HLA-820 was created on JIRA by Michele De La Pena:
While fitsblender (ci.yml and tox.ini) can now use GitHub Actions in an effort to migrate away from Azure, there are still some improvements which can be done to the ci.yml and tox.ini files, as well as other configuration files associated with this package. Improvements as noted in the review of PR#36:
You can probably rename the
setup.cfg
->{}.flake8{
}, if you want, as it only containsflake8
configuration.Additionally,
setuptools>=60
currently officially supports reading project metadata frompyproject.toml
(in the[project]
table) in accordance with PEP621.setuptools
will also (eventually) officially support using the[tool.setuptools]
table inpyproject.toml
when Python 3.11 is released. Keeping metadata insetup.py
andsetup.cfg
is fine for the forseeable future, but I expect that both files will eventually be deprecated as more and more configuration moves to{}pyproject.toml{
}.Here's an example of using
pyproject.toml
for configuration: https://github.com/spacetelescope/jwst/pull/6847/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711In addition, there should be a code coverage test added to ci.yml. Also consider platform.platform() in the fitsblender code so the OS can be reported in the log (MacOS 11 vs MacOS 12).