spacetelescope / drizzlepac

AstroDrizzle for HST images.
https://drizzlepac.readthedocs.io
BSD 3-Clause "New" or "Revised" License
52 stars 38 forks source link

Error due to incompatibility with numpy 1.25 #1601

Open rosteen opened 1 year ago

rosteen commented 1 year ago

Hi,

I recently had a test in another package start failing, and it turns out it's due to an error thrown with the combination of drizzlepac and numpy version 1.25.0. I assume this is a simple fix in drizzlepac to change this comparison, but I don't have time right this moment to do it myself. Here's the traceback:

Traceback (most recent call last):
  File "/home/runner/work/slitlessutils/slitlessutils/.tox/py310-test-alldeps-cov/lib/python3.10/site-packages/drizzlepac/util.py", line 230, in wrapper
    result = func(*args, **kwargs)
  File "/home/runner/work/slitlessutils/slitlessutils/.tox/py310-test-alldeps-cov/lib/python3.10/site-packages/drizzlepac/astrodrizzle.py", line 223, in run
    createMedian.createMedian(imgObjList, configobj, procSteps=procSteps)
  File "/home/runner/work/slitlessutils/slitlessutils/.tox/py310-test-alldeps-cov/lib/python3.10/site-packages/drizzlepac/createMedian.py", line 99, in createMedian
    _median(imgObjList, paramDict)
  File "/home/runner/work/slitlessutils/slitlessutils/.tox/py310-test-alldeps-cov/lib/python3.10/site-packages/drizzlepac/createMedian.py", line 395, in _median
    result = min_med(
  File "/home/runner/work/slitlessutils/slitlessutils/.tox/py310-test-alldeps-cov/lib/python3.10/site-packages/drizzlepac/minmed.py", line 424, in min_med
    if weight_masks == [] or weight_masks is None:
ValueError: operands could not be broadcast together with shapes (2,61,4297) (0,)
stscijgbot-hstdp commented 1 year ago

This issue is tracked on JIRA as HLA-1043.

stscijgbot-hstdp commented 9 months ago

Comment by Michele De La Pena on JIRA:

This issue was addressed by Mihai 029935f (PR#⁠1753).