search

spacetelescope / drizzlepac

AstroDrizzle for HST images.
https://drizzlepac.readthedocs.io
BSD 3-Clause "New" or "Revised" License
52 stars 38 forks source link

VerifyWarning: Card is too long, comment will be truncated #19

Closed pllim closed 7 years ago

pllim commented 7 years ago

Example test: https://ssb.stsci.edu/pandokia/pandokia.cgi?query=detail&key_id=36464239

[WARNING ] VerifyWarning: Card is too long, comment will be truncated.
mcara commented 7 years ago

See my comment https://github.com/spacetelescope/drizzlepac/issues/18#issuecomment-277499137

CC: @nden @stsci-hack

mcara commented 7 years ago

@nden @stsci-hack I think the only way to fix this is to rename keywords used in our headers to make their names shorter such as, e.g., IDCSCALE which, when "archived" becomes IDCSCALEO (9 characters). Most likely this is not possible... Another option would be to disable warnings in updatewcs() but I think this is a wrong approach as then we might miss some legitimate warnings.

philhodge commented 7 years ago

An alternative is to use a shorter comment, maybe much shorter. If the warning is "comment will be truncated", then we could just ask DMS to use a shorter comment string when creating the raw file.

On 02/06/2017 01:13 PM, Mihai Cara wrote:

@nden https://github.com/nden @stsci-hack https://github.com/stsci-hack I think the only way to fix this is to rename keywords used in our headers to make their names shorter such as, e.g., |IDCSCALE| which, when "archived" becomes |IDCSCALEO| (9 characters). Most likely this is not possible... Another option would be to disable warnings in |updatewcs()| but I think this is a wrong approach as then we might miss some legitimate warnings.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/spacetelescope/drizzlepac/issues/19#issuecomment-277765483, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-FDNeEkPG1-DFet5zU11dRRZgGhJ9Mks5rZ2LMgaJpZM4Lsu2Y.

mcara commented 7 years ago

@philhodge I do not think that a shorter comment will help. The problem is in long keyword names. The warning message is:

Keyword name 'IDCSCALEO' is greater than 8 characters or contains characters not allowed by the FITS standard; a HIERARCH card will be created.

Also see https://heasarc.gsfc.nasa.gov/docs/software/fitsio/c/f_user/node28.html

mcara commented 7 years ago

@philhodge Ah, my bad... there is also another warning (the one mentioned in the original description of the issue):

[WARNING ] VerifyWarning: Card is too long, comment will be truncated.

That one may be solved as you suggest.

pllim commented 7 years ago

Keyword name 'IDCSCALEO' is greater than 8 characters...

@mcara , I am so glad that you are already working on this one, as I was just about to open another issue for it... :joy:

mcara commented 7 years ago

@stsci-hack @nden @pllim No, I am not working on this issue as I do not really know what to do about it. This is not really related to astrodrizzle software but rather to the length of the keywords used at STScI. I do not know who is responsible for re-defining keywords at STScI but it is definitely not me.

pllim commented 7 years ago

By the way, you can always tag this issue was "wont fix" and close it if it is out of scope.

mcara commented 7 years ago

Good to know. However, maybe it is worth keeping open until @stsci-hack gets a chance to look at it. Even though it is not a software issue (in my opinion), maybe it is something to be raised with other teams.

mcara commented 7 years ago

Fundamentally, this is not a problem with drizzlepac but rather due to the fact that STScI uses long comments in headers.