search

spacetelescope / drizzlepac

AstroDrizzle for HST images.
https://drizzlepac.readthedocs.io
BSD 3-Clause "New" or "Revised" License
50 stars 39 forks source link

MVM: Revise overloaded constructor for SkyCell class #868

Closed stscijgbot-hstdp closed 2 years ago

stscijgbot-hstdp commented 3 years ago

Issue HLA-453 was created on JIRA by Warren Hack:

The API for instantiating the SkyCell class currently has a number of parameters which can be provided.  However, when the first parameter is provided, it will ignore the values for all the remaining parameters except the 'scale' parameter.  This 'overloading' of the constructor is prone to user-error or confusion and should be revised to avoid this problem.  

Michele provided the following reference as a pattern to use to revise this interface:

https://medium.com/@shamir.stav_83310/overloading-constructors-in-python-17e42b7430b6](https://medium.com/@shamir.stav_83310/overloading-constructors-in-python-17e42b7430b6)

The current interface works, so this work is not critical, but would make the code more robust when being used for manual reprocessing by an end-user.

stscijgbot-hstdp commented 3 years ago

Comment by Warren Hack on JIRA:

This will be addressed with Drizzlepac PR #⁠878.

stsci-hack commented 2 years ago

Resolved by #878.