spacetelescope / drizzlepac

AstroDrizzle for HST images.
https://drizzlepac.readthedocs.io
BSD 3-Clause "New" or "Revised" License
50 stars 39 forks source link

Update Drizzlepac to support Python 3.8 #968

Closed stscijgbot-hstdp closed 2 years ago

stscijgbot-hstdp commented 3 years ago

Issue HLA-503 was created on JIRA by Warren Hack:

The Drizzlepac package, and all the SVM and MVM processing code, will need to be upgraded to work under Python 3.8. Changes to Python 3.8 libraries have been reported to cause exceptions, specifically with regards to AstroDrizzle's use of the multiprocessing module.

Given that Python 3.10 is now out, we need to update Drizzlepac to work under (at least) Python 3.8. This work should start by implementing the changes needed to get multiprocessing working under Python >= 3.8. Syntax changes due to Python 3.8 changes should be limited to those which cause changes in the results or which result in exceptions.

stscijgbot-hstdp commented 3 years ago

Comment by Robert Swaters on JIRA:

We will need additional and separate tickets for updating tests after the python upgrade.

stscijgbot-hstdp commented 3 years ago

Comment by Warren Hack on JIRA:

We also will need to update the build process for releases to build wheels for Drizzlepac as well.

stscijgbot-hstdp commented 3 years ago

Comment by Mihai Cara on JIRA:

Changes to Python 3.8 libraries have been reported to cause exceptions, specifically with regards to AstroDrizzle's use of the multiprocessing module.

Fixed via #1101

Drizzlepac's multiprocessing should be running fine now in Python >= 3.8. The fix is also backward compatible with Python 3.6, 3.7.

stscijgbot-hstdp commented 3 years ago

Comment by Nadia Dencheva on JIRA:

I tried adding this ticket to periwinkle's board but it didn't work which is fine, it's this one ticket only. The PR is ready for review.

stscijgbot-hstdp commented 3 years ago

Comment by Mihai Cara on JIRA:

PR was reviewed and merged. This ticket should be moved to "Done" (or testing).