Port trapezoid fit from DAVE

spacetelescope / exovetter

Exoplanet vetting

https://exovetter.readthedocs.io

BSD 3-Clause "New" or "Revised" License

6 stars 5 forks source link

Closed pllim closed 4 years ago

pllim commented 4 years ago

Fix #13

TODO

[x] Refactor original code.
[x] Make test pass.
[x] Use a seed to handle randomness in testing.
[ ] Use astropy.units.Quantity? Let's defer this as a future PR. Lots of magic numbers to sort out. See #16

fergalm commented 4 years ago

Looking at the code now. I agree with you on deferring the move to astropy quantities for the moment.

pllim commented 4 years ago

As discussed today, I will merge this and we can improve on it as future PRs. Thank you, everyone!