search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

added a phase coverage vetter #24

Closed mustaric closed 4 years ago

mustaric commented 4 years ago

A start on a simple coverage vetter. It still needs to be added to the vetters.py and tests moved to the correct place.

EDIT: Fix #22

pllim commented 4 years ago

Tip: Instead of "do not merge" label, which still allows accidental merging, it is safer to turn this into a draft PR, which disables the merge button completely. When you are ready, you can convert it to a "normal" PR with one click. This does not affect the CI. I'll turn it into a draft PR for you now.

mustaric commented 4 years ago

I'll try to remember that (assuming I can find the button). I'm not sure how I see how to change it back to a normal PR, so when the time comes I'll need you to show me that one click button.

pllim commented 4 years ago

It is the "Ready for Review" button.

mustaric commented 4 years ago

We will save creating the vetting class for another pull request.