search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Replace Tce class #26

Closed fergalm closed 4 years ago

fergalm commented 4 years ago

This is a proposal for a new TCE class. It adds small modifications to a standard python dictionary. It ensures that certain quantities (period, depth, duration etc.) are astropy Quantities, and refuses to accept efforts to set their values to non-Quantities (e.g floats).

It also adds a method get_model() which returns a model transit in the requested time system (e.g bkjd, bjd etc.).

pllim commented 4 years ago

I am going to turn this into a draft PR. When you think it is truly ready for review, you can remove the draft status and ping us again. 😄

fergalm commented 4 years ago

Modulo pep8 details, this PR is ready for review. The Tce is a standalone data class, while model generation has been separated off into models.py