search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

[model.py] Refactor to use astropy.modeling or at least a class #32

Open pllim opened 3 years ago

pllim commented 3 years ago

Currently, the instruction is to create two functions for each model (#26). Why can't we:

  1. Make each model a class with constructor taking fundamental inputs (arrays, etc) and a separate class method to take TCE?
  2. Inherit from astropy.modeling.models base class by taking advantage of its ability to specify custom models.
  3. And if we want to enable the machinery beyond boxcar and trapezoid, define an abstract base class for all models (existing and future).