spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Add SWEET vetter (updated) #36

Closed pllim closed 3 years ago

pllim commented 3 years ago

This superseded #25 . I also applied comments from that PR.

Fix #21

p.s. You can ignore the coverage "failures".

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (8e91a96) into master (c8b64ef) will decrease coverage by 0.59%. The diff coverage is 78.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   82.66%   82.07%   -0.60%     
==========================================
  Files          11       12       +1     
  Lines         652      809     +157     
==========================================
+ Hits          539      664     +125     
- Misses        113      145      +32     
Impacted Files Coverage Δ
exovetter/utils.py 69.74% <69.74%> (ø)
exovetter/vetters.py 94.66% <96.07%> (+16.54%) :arrow_up:
exovetter/lpp.py 74.86% <100.00%> (-0.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8b64ef...8e91a96. Read the comment docs.

pllim commented 3 years ago

Do you find the code coverage notifications within the diffs helpful?

I actually do. I find it more helpful than the status checks (which I have learned to just ignore).

fergalm commented 3 years ago

I had a look at this last night. There was a bit more to do than I thought (DAVE does work to the lightcurve before it gives it to the sweet test, we don't). I got close to something I could push, but it'll need another evening of my time.

pllim commented 3 years ago

No rush on my end. Thanks for looking into it, @fergalm !