spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Add vetters #37

Closed mustaric closed 3 years ago

mustaric commented 3 years ago

I've added vetters for each test and fixed up the tests. Fingers crossed the tests will now pass. I still need to put rework the tces for the lpp test.

codecov[bot] commented 3 years ago

Codecov Report

Merging #37 (77dc5d5) into master (c8b64ef) will decrease coverage by 21.39%. The diff coverage is 36.84%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #37       +/-   ##
===========================================
- Coverage   82.66%   61.27%   -21.40%     
===========================================
  Files          11       11               
  Lines         652      692       +40     
===========================================
- Hits          539      424      -115     
- Misses        113      268      +155     
Impacted Files Coverage Δ
exovetter/lpp.py 11.95% <0.00%> (-63.05%) :arrow_down:
exovetter/trapezoid_fit.py 86.97% <0.00%> (ø)
exovetter/transit_coverage.py 71.42% <25.00%> (-28.58%) :arrow_down:
exovetter/vetters.py 35.08% <28.12%> (-43.04%) :arrow_down:
exovetter/odd_even.py 80.85% <80.00%> (-4.15%) :arrow_down:
exovetter/const.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8b64ef...77dc5d5. Read the comment docs.

pllim commented 3 years ago

I still need to put rework the tces for the lpp test.

Please ping me when you think this is ready for review. I'll wait. Thanks!

mustaric commented 3 years ago

I'm going to merge this without reworking the lpp test. I want to do that on another branch. So for the moment I just removed those lpp tests. So assuming the tests pass, this is ready for review, @pllim.

The big thing to look at is how I added the odd even and phase coverage to vetters.py.

pllim commented 3 years ago

59.19% (-23.48%) -- Oof... definitely need more test coverage in your follow up PR. 😉

Thanks. I'll have a look soon.

mustaric commented 3 years ago

I really am unsure how vetters2.py ended up in this repository. I will attempt to do a git remove. I don't know when it got git added.

mustaric commented 3 years ago

Any objections to merging this?

pllim commented 3 years ago

Merged. Thanks!