search

spacetelescope / exovetter

Exoplanet vetting
https://exovetter.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Add Vetting Test, improve odd_even vetter #40

Closed mustaric closed 3 years ago

mustaric commented 3 years ago

In this pull request I added a vetters test that tests LPP, Odd Even and transit coverage. I have also included a start to an example TCE notebook to show our current functionality to the users. In the process I fixed a couple of bugs in the odd-even vetter and brought the transit duration fraction up as an input to the function.

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (d6c937b) into master (d655b84) will increase coverage by 21.67%. The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #40       +/-   ##
===========================================
+ Coverage   61.27%   82.94%   +21.67%     
===========================================
  Files          11       11               
  Lines         692      692               
===========================================
+ Hits          424      574      +150     
+ Misses        268      118      -150
Impacted Files Coverage Δ
exovetter/lpp.py 74.86% <ø> (+62.90%) :arrow_up:
exovetter/odd_even.py 80.85% <80.00%> (ø)
exovetter/vetters.py 94.82% <100.00%> (+59.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d655b84...d6c937b. Read the comment docs.

pllim commented 3 years ago

@mustaric , is this ready for final review? Thanks!

mustaric commented 3 years ago

I thought so, but I just thought of one more thing I wanted to do...hold on.

mustaric commented 3 years ago

@pllim this is ready for your review In this pull request 1) Fixed issues with the odd_even test (median instead of average and a problem with the span for the out of transit cadences). I also improved the plotting. 2) Fixed the TCE problem in the second odd_even test. 3) Wrote a vetters test that runs odd_even, lpp and transit coverage. We can add more tests to this end-to-end as needed. 4) Commented out the extra lpp tests. If you agree I'll remove them and let test_vetters just do that piece of the testing.

pllim commented 3 years ago

Merged. Have a good weekend!